-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103942/#review10567
-----------------------------------------------------------


Seems like lots of code of the unar.cpp is "copied" from unrar.cpp could you
just generalize/share it? Having "duplicate" code is not good.


generators/comicbook/document.cpp
<http://git.reviewboard.kde.org/r/103942/#comment8640>

Please remove this comment



generators/comicbook/document.cpp
<http://git.reviewboard.kde.org/r/103942/#comment8641>

is the 1.0 needed?



generators/comicbook/unar.h
<http://git.reviewboard.kde.org/r/103942/#comment8642>

const?



generators/comicbook/unar.cpp
<http://git.reviewboard.kde.org/r/103942/#comment8643>

Bad spacing


- Albert Astals Cid


On Feb. 12, 2012, 4:09 p.m., David Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103942/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2012, 4:09 p.m.)
>
>
> Review request for Okular.
>
>
> Description
> -------
>
> This change adds support for 7z archives using "unar", the commandline
> decompressor from The Unarchiver[1].
>
> This diff is based on the "Simplify mimetype queries" diff.
>
> [1] http://wakaba.c3.cx/s/apps/unarchiver
>
>
> Diffs
> -----
>
> generators/comicbook/CMakeLists.txt 067a07a
> generators/comicbook/document.h 22c3213
> generators/comicbook/document.cpp 3ba7483
> generators/comicbook/libokularGenerator_comicbook.desktop bec8c92
> generators/comicbook/okularApplication_comicbook.desktop 285f19d
> generators/comicbook/okularComicbook.desktop 4d70d70
> generators/comicbook/unar.h PRE-CREATION
> generators/comicbook/unar.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/103942/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Palacio
>
>

_______________________________________________
Okular-devel mailing list
Okular-devel@xxxxxxx
https://mail.kde.org/mailman/listinfo/okular-devel